Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong usage of QueryStringDecoder.decodeComponent in PathPattern #590

Open
finalchild opened this issue Dec 11, 2023 · 0 comments
Open

Wrong usage of QueryStringDecoder.decodeComponent in PathPattern #590

finalchild opened this issue Dec 11, 2023 · 0 comments

Comments

@finalchild
Copy link

finalchild commented Dec 11, 2023

Describe the bug
PathPattern calls QueryStringDecoder.decodeComponent, which replaces '+' to ' '.

This behavior is expected in query strings, but not in path strings.

(FYI, QueryStringDecoder.decodeComponent has an overloaded version that allows setting isPath=true, but this is a private method.)

To Reproduce
I'm not familiar with finatra, so I don't know what exactly this bug affects, but it seems incoming path decoding would not be working properly.

Expected behavior
"as+df" should be decoded to "as+df", not "as df".

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
For web, specify your OS and browser version. For mobile, specify device, OS
and version. For libraries, what version of build tools are you using?

Additional context
I ran into this code digging into a similar tapir bug: softwaremill/tapir#3384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant