-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse wont auto height on IE #2131
Comments
Is there anyone who can reproduce this? |
What steps are required to reproduce this? |
I have the Collapse plugin with a few blocks. My last block contains the dynatree (http://code.google.com/p/dynatree/). When the dynatree expands the collapse wont adjust height because the height is set to the inline element. Firefox/Chrome work the way as expected though. Hope you can reproduce it. I think its more that it wont adjust its height with dynamic JS in IE. |
Any progress on this? |
your best bet is going to be to provide a working link or jsfiddle so that we can see what your running into and toy with it.the inline part is interesting but in general I don't believe BS should be responsible for fixing every 3rd party issue at the expense of a huge codebase. there will always be certain setups that have issues, we almost need a user forum for this kind of stuff. |
Here is the JSFiddle example: http://jsfiddle.net/cRvmh/1/ As you can see it has nothing todo with the 3th party software like Dynatree but more like the Collapse itself. If you check the last tab you see a click link. In Bootstrap 2.0.1 the content div of that tab wont resize with the dynamic content. In Bootstrap 2.0.2 it does the same but the inside content will be put on top of the tab content. As you can see there is more broken in the collapse in IE. Also the tabs wont open correctly. |
this this is a css issue, we'll have mark look at it, thanks! |
+1 Same Error seems to apply for the tabs |
Ok thnx. Made a quickfix in my app with JS so take your time :) |
This can be fixed by changing line 58 in this.$element[dimension](this.$element[0][scroll]) to $.support.transition && this.$element[dimension](this.$element[0][scroll]) |
This should be resolved—it wasn't specifically an IE bug as we saw this behavior everywhere. |
This bug is still there? |
philBrown.....THANK YOU Brother!!! That was driving me nuts. Worked everywhere but IE til I applied your fix. |
Really Thanks |
philBrown dude, shot! Was having this issue with Bootstrap v2.0.2 & IE9. Changing that line in the bootstrap js file sorted the problem out. |
I did notice with latest version this wasn't a problem anymore. FWIW. |
I am still having this issue w/ 2.0.4 , this jsfiddle demonstrates what I'm doing. In IE, adding elements to the uncollapsed div are obscured. If I'm doing something wrong, I'm all ears. |
I just noticed that this was fixed only in 2.1.0 and not in 2.0.4. Good to know. Patching my local files works. |
2.1? Didn't know there was a version past 2.04. |
https://github.com/twitter/bootstrap/tree/2.1.0-wip , the next release? |
The Collapse sets the height with an inline value on IE. This causes a problem while adding dynamic content with a variable height (in my case the dynatree).
Firefox / Chrome work correct.
The text was updated successfully, but these errors were encountered: