Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile library #472

Open
C0D3-M4513R opened this issue Jan 14, 2025 · 4 comments
Open

Cannot compile library #472

C0D3-M4513R opened this issue Jan 14, 2025 · 4 comments
Labels

Comments

@C0D3-M4513R
Copy link
Contributor

C0D3-M4513R commented Jan 14, 2025

I cannot seem to compile my project, which includes this library in github actions:

https://github.com/C0D3-M4513R/MeAndTheBoisBot/actions/runs/12771371038/job/35598371252#step:6:1

I assume, that this happens because the Readme file is maybe not included in the crate package when vendoring?
(https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields)

Edit: it is included in the Cargo.toml, but not present after cargo vendor? Is this a bug in cargo?

@C0D3-M4513R
Copy link
Contributor Author

C0D3-M4513R commented Jan 14, 2025

For now I've worked around this issue, by doing this:
https://github.com/C0D3-M4513R/MeAndTheBoisBot/compare/f794fb9b4711f16935249b9a8836c871ecdfb906..fb01e07b790b109e2ddd7e9c9316a9894ca745b0

Ideally though this wouldn't be necessary.

@Emilgardis
Copy link
Member

I have no clue why this is not working :/

@Nerixyz
Copy link
Contributor

Nerixyz commented Jan 14, 2025

Seems like this is a cargo vendor bug (maybe because we specify ./README.md and not README.md?, I couldn't imagine how, though).

> cargo package --list | head -n 10
.cargo_vcs_info.json
CHANGELOG.md
CONTRIBUTING.md
Cargo.lock
Cargo.toml
Cargo.toml.orig
LICENSE-APACHE
LICENSE-MIT
README.md
examples\README.md

If you look at https://github.com/rust-lang/cargo/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3ACommand-vendor, there are a few issues related to files not being found.

@C0D3-M4513R
Copy link
Contributor Author

C0D3-M4513R commented Jan 17, 2025

Looking at issues, this seems like rust-lang/cargo#14034 or rust-lang/cargo#9555 to me. So this is an upstream cargo issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants