Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for:
serial
extra on PyPy on Windows. Anything else?Scope and purpose
Add a few words about why this PR is needed and what is its scope.
Add mentions of things that are not covered here and are planed to be done
in separate PRs.
Remove this section
Please have a look at our developer documentation before submitting your Pull Request.
Please note that the trac ticket, news fragment, and review submission portions of this process apply to all pull requests, no matter how small; if you don't do them, it's likely that nobody will even notice your PR needs a review.
Contributor Checklist:
tox -e lint
to format my patch to meet the Twisted Coding Standardreview
to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.