Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to accommodate Twisted's new URL validity checking #247

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

glyph
Copy link
Member

@glyph glyph commented Jun 11, 2019

The tests are currently failing on master for the -latest environments.

@glyph glyph requested a review from a team June 11, 2019 19:16
Copy link
Member

@hawkowl hawkowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@glyph
Copy link
Member Author

glyph commented Jun 11, 2019

ignoring codecov because of its apparently permanent outage, will switch to coveralls soon

@glyph glyph merged commit 10f30f4 into master Jun 11, 2019
@glyph glyph deleted the latest-twisted-test-incompatibility branch June 11, 2019 20:59
twm added a commit to twm/treq that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants