You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation currently documents _Response, which raises the question of what that underscore prefix is doing there exactly.
Instead, we should define a treq.itreq.IHelpfulResponse (better name pending) which documents all the extra attributes and is a sub-interface of Agent's IResponse, then document that rather than _Response itself. (Needless to say, _Response should then implement said interface.)
The documentation currently documents
_Response
, which raises the question of what that underscore prefix is doing there exactly.Instead, we should define a
treq.itreq.IHelpfulResponse
(better name pending) which documents all the extra attributes and is a sub-interface of Agent'sIResponse
, then document that rather than_Response
itself. (Needless to say,_Response
should then implement said interface.)This would make it possible to write correct type annotations when https://github.com/Shoobx/mypy-zope has been updated to work with the latest mypy.
The text was updated successfully, but these errors were encountered: