From c5360340075e8249c76ac902b5110bc0e1ccab93 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 14:32:11 -0800
Subject: [PATCH 01/18] GitHub Actions CI config

---
 .github/workflows/ci.yaml | 107 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 107 insertions(+)
 create mode 100644 .github/workflows/ci.yaml

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
new file mode 100644
index 00000000..4822b903
--- /dev/null
+++ b/.github/workflows/ci.yaml
@@ -0,0 +1,107 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  lint:
+    runs-on: ubuntu-20.04
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - uses: actions/setup-python@v2
+      with:
+        python-version: '3.8'
+
+    - uses: actions/cache@v2
+      with:
+        path: ~/.cache/pip
+        key:
+          ${{ runner.os }}-pip-lint-${{ hashFiles('pyproject.toml', 'setup.py', 'tox.ini') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-lint-
+          ${{ runner.os }}-pip-
+
+    - run: python -m pip install tox
+
+    - run: tox -q -e flake8
+
+    - run: tox -q -e towncrier
+
+    - run: tox -q -e twine
+
+    - run: tox -q -e check-manifest
+
+
+  docs:
+    runs-on: ubuntu-20.04
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - uses: actions/setup-python@v2
+      with:
+        python-version: "3.8"
+
+    - uses: actions/cache@v2
+      with:
+        path: ~/.cache/pip
+        key:
+          ${{ runner.os }}-pip-docs-${{ hashFiles('pyproject.toml', 'setup.py', 'tox.ini') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-docs-
+          ${{ runner.os }}-pip-
+
+    - run: python -m pip install tox
+
+    - run: tox -q -e docs
+
+
+  test:
+    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+          python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7", "pypy-3.7"]
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - uses: actions/cache@v2
+      with:
+        path: ~/.cache/pip
+        key:
+          ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ hashFiles('pyproject.toml', 'setup.py', 'tox.ini') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-${{ matrix.python-version }}-
+          ${{ runner.os }}-pip-
+
+    - name: Translate Python version to Tox factor
+      id: pyfactor
+      shell: python
+      run: |
+        table = {
+          "2.7": "py27",
+          "3.5": "py35",
+          "3.6": "py36",
+          "3.7": "py37",
+          "3.8": "py38",
+          "3.9": "py39",
+          "pypy-2.7": "pypy",
+          "pypy-3.7": "pypy3",
+        }
+        factor = table["${{ matrix.python-version }}"]
+        print("::set-output name=value::" + factor)
+
+    - run: python -m pip install tox
+
+    - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_lowest
+
+    - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_latest

From 237fb6f142b0ed7ea6434dfe32e82ab48df59515 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 15:11:52 -0800
Subject: [PATCH 02/18] Set minimum Twisted to 18.7.0

This seems sufficiently ancient as a lower bound.
---
 setup.py | 3 +--
 tox.ini  | 7 ++-----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/setup.py b/setup.py
index 473ed2fb..6d5e24de 100644
--- a/setup.py
+++ b/setup.py
@@ -33,8 +33,7 @@
             "requests >= 2.1.0",
             "hyperlink >= 19.0.0",
             "six >= 1.13.0",
-            "Twisted[tls] >= 16.4.0 ; python_version < '3.7'",
-            "Twisted[tls] >= 18.7.0 ; python_version >= '3.7'",
+            "Twisted[tls] >= 18.7.0",
             "attrs",
         ],
         extras_require={
diff --git a/tox.ini b/tox.ini
index 942321d2..663a262c 100644
--- a/tox.ini
+++ b/tox.ini
@@ -2,7 +2,7 @@
 envlist =
     {pypy,py27,py35,py36,py37}-twisted_lowest,
     {pypy,pypy3,py27,py35,py36,py37,py38}-twisted_latest,
-    {pypy3,py35,py36,py37,py38}-twisted_trunk-pyopenssl_trunk,
+    {pypy3,py35,py36,py37,py38}-twisted_trunk,
     towncrier, twine, check-manifest, flake8, docs
 
 [testenv]
@@ -11,13 +11,10 @@ deps =
     coverage
     mock
 
-    !py37-twisted_lowest: Twisted==16.4.0
-    py37-twisted_lowest: Twisted==18.7.0
+    twisted_lowest: Twisted==18.7.0
     twisted_latest: Twisted
     twisted_trunk: https://github.com/twisted/twisted/archive/trunk.zip
 
-    pyopenssl_trunk: https://github.com/pyca/pyopenssl/archive/master.zip
-
     docs: Sphinx>=1.4.8
 setenv =
     # Avoid unnecessary network access when creating virtualenvs for speed.

From c34dcb3effdd29b7a7618a6f8d84cc61758753a4 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 15:12:44 -0800
Subject: [PATCH 03/18] Twisted versions in matrix

---
 .github/workflows/ci.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 4822b903..69c9c50b 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -66,6 +66,7 @@ jobs:
     strategy:
       matrix:
           python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7", "pypy-3.7"]
+          twisted-version: ["lowest", "latest", "trunk"]
 
     steps:
     - uses: actions/checkout@v2
@@ -102,6 +103,4 @@ jobs:
 
     - run: python -m pip install tox
 
-    - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_lowest
-
-    - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_latest
+    - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_${{ matrix.twisted-version }}

From fe5ca650e5bbb41a87c3395a56eebfd90282149f Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 15:23:03 -0800
Subject: [PATCH 04/18] Make PyPy3 and trunk builds experimental

---
 .github/workflows/ci.yaml | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 69c9c50b..89b7e9ed 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -63,10 +63,21 @@ jobs:
 
   test:
     runs-on: ubuntu-20.04
+    continue-on-error: ${{ matrix.experimental }}
     strategy:
       matrix:
-          python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7", "pypy-3.7"]
-          twisted-version: ["lowest", "latest", "trunk"]
+          python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7"]
+          twisted-version: ["lowest", "latest"]
+          experimental: [false]
+
+          include:
+          - python-version: "pypy-3.7"
+            twisted-version: "latest"
+            experimental: true
+
+          - python-version: "3.8"
+            twisted-version: "trunk"
+            experimental: true
 
     steps:
     - uses: actions/checkout@v2

From b019e20bf6392b2c04c2a26be80218bdcbba8da0 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 15:27:17 -0800
Subject: [PATCH 05/18] Add timeouts

---
 .github/workflows/ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 89b7e9ed..6f809431 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -9,6 +9,7 @@ on:
 jobs:
   lint:
     runs-on: ubuntu-20.04
+    timeout-minutes: 5
 
     steps:
     - uses: actions/checkout@v2
@@ -39,6 +40,7 @@ jobs:
 
   docs:
     runs-on: ubuntu-20.04
+    timeout-minutes: 5
 
     steps:
     - uses: actions/checkout@v2
@@ -63,6 +65,7 @@ jobs:
 
   test:
     runs-on: ubuntu-20.04
+    timeout-minutes: 10
     continue-on-error: ${{ matrix.experimental }}
     strategy:
       matrix:

From 6e698afed4a899e17f6e8c8d0f67bc50b280fa2e Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 16:27:53 -0800
Subject: [PATCH 06/18] Increase RSA key size for PyPy3

The PyPy builds are failing due to our good friend Twisted #9985 [1]:

    main function encountered error
    Traceback (most recent call last):
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks
        _inlineCallbacks(None, g, status)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
        result = g.send(result)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/treq/test/local_httpbin/child.py", line 175, in _serve_tls
        port = yield endpoint.listen(site)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/endpoints.py", line 1092, in listen
        interface=self._interface)
    --- <exception caught here> ---
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/treq/test/local_httpbin/child.py", line 175, in _serve_tls
        port = yield endpoint.listen(site)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/defer.py", line 122, in execute
        result = callable(*args, **kw)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/posixbase.py", line 521, in listenSSL
        tlsFactory = tls.TLSMemoryBIOFactory(contextFactory, False, factory)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/protocols/tls.py", line 773, in __init__
        contextFactory = _ContextFactoryToConnectionFactory(contextFactory)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/protocols/tls.py", line 651, in __init__
        oldStyleContextFactory.getContext()
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/_sslverify.py", line 1678, in getContext
        self._context = self._makeContext()
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/_sslverify.py", line 1688, in _makeContext
        ctx.use_certificate(self.certificate)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/OpenSSL/SSL.py", line 865, in use_certificate
        _raise_current_error()
      File "/usr/lib/pypy3/lib_pypy/_functools.py", line 80, in __call__
        return self._func(*(self._args + fargs), **fkeywords)
      File ".../treq/.tox/pypy3-twisted_latest/site-packages/OpenSSL/_util.py", line 57, in exception_from_error_queue
        raise exception_type(errors)
    OpenSSL.SSL.Error: [('SSL routines', 'SSL_CTX_use_certificate', 'ee key too small')]

[1]: https://twistedmatrix.com/trac/ticket/9985
---
 src/treq/test/local_httpbin/child.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/treq/test/local_httpbin/child.py b/src/treq/test/local_httpbin/child.py
index 5b972b49..dcd1f797 100644
--- a/src/treq/test/local_httpbin/child.py
+++ b/src/treq/test/local_httpbin/child.py
@@ -35,7 +35,7 @@
 from .shared import _HTTPBinDescription
 
 
-def _certificates_for_authority_and_server(service_identity, key_size=1024):
+def _certificates_for_authority_and_server(service_identity, key_size=2048):
     """
     Create a self-signed CA certificate and server certificate signed
     by the CA.
@@ -44,8 +44,8 @@ def _certificates_for_authority_and_server(service_identity, key_size=1024):
     :type service_identity: :py:class:`unicode`
 
     :param key_size: (optional) The size of CA's and server's private
-        RSA keys.  Defaults to 1024 bits, which is the minimum allowed
-        by OpenSSL Contexts at the default security level as of 1.1.
+        RSA keys.  Defaults to 2048 bits, which is the minimum allowed
+        by OpenSSL Contexts at the default security level.
     :type key_size: :py:class:`int`
 
     :return: a 3-tuple of ``(certificate_authority_certificate,

From 46b087885eaee1e86c2eef700a5a154f193b8000 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 16:42:38 -0800
Subject: [PATCH 07/18] Remove Travis CI config

---
 .travis.yml | 78 -----------------------------------------------------
 1 file changed, 78 deletions(-)
 delete mode 100644 .travis.yml

diff --git a/.travis.yml b/.travis.yml
deleted file mode 100644
index ecbc6b40..00000000
--- a/.travis.yml
+++ /dev/null
@@ -1,78 +0,0 @@
-# AUTO-GENERATED BY tox2travis.py -- DO NOT EDIT THIS FILE BY HAND!
-
-dist: xenial
-language: python
-
-cache: pip
-
-jobs:
-  include:
-    - python: "3.8"
-      env: TOXENV=towncrier,twine,check-manifest,flake8,docs
-    - python: "2.7"
-      env: TOXENV=py27-twisted_lowest,py27-twisted_latest
-    - python: "3.5"
-      env: TOXENV=py35-twisted_lowest,py35-twisted_latest
-    - python: "3.6"
-      env: TOXENV=py36-twisted_lowest,py36-twisted_latest
-    - python: "3.7"
-      env: TOXENV=py37-twisted_lowest,py37-twisted_latest
-    - python: "3.8"
-      env: TOXENV=py38-twisted_latest
-    - python: "pypy"
-      env: TOXENV=pypy-twisted_lowest,pypy-twisted_latest
-    - python: "pypy3"
-      env: TOXENV=pypy3-twisted_latest
-    - python: "pypy3"
-      env: TOXENV=pypy3-twisted_trunk-pyopenssl_trunk
-      if: branch = master
-    - python: "3.5"
-      env: TOXENV=py35-twisted_trunk-pyopenssl_trunk
-      if: branch = master
-    - python: "3.6"
-      env: TOXENV=py36-twisted_trunk-pyopenssl_trunk
-      if: branch = master
-    - python: "3.7"
-      env: TOXENV=py37-twisted_trunk-pyopenssl_trunk
-      if: branch = master
-    - python: "3.8"
-      env: TOXENV=py38-twisted_trunk-pyopenssl_trunk
-      if: branch = master
-
-  # Don't fail on trunk versions.
-  allow_failures:
-    - env: TOXENV=pypy3-twisted_trunk-pyopenssl_trunk
-    - env: TOXENV=py35-twisted_trunk-pyopenssl_trunk
-    - env: TOXENV=py36-twisted_trunk-pyopenssl_trunk
-    - env: TOXENV=py37-twisted_trunk-pyopenssl_trunk
-    - env: TOXENV=py38-twisted_trunk-pyopenssl_trunk
-
-before_install:
-  - pip install --upgrade pip
-  - pip install --upgrade setuptools
-
-install:
-  - pip install tox coveralls
-
-script:
-  - tox
-
-after_success:
-  - coveralls
-
-after_failure:
-  - |
-    if [[ -f "_trial_temp/httpbin-server-error.log" ]]
-    then
-        echo "httpbin-server-error.log:"
-        cat "_trial_temp/httpbin-server-error.log"
-    fi
-
-notifications:
-  email: false
-
-branches:
-  only:
-    - master
-
-# AUTO-GENERATED BY tox2travis.py -- DO NOT EDIT THIS FILE BY HAND!

From 2d31fa9242e47ccf36142730b13bff989ca58778 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 16:52:47 -0800
Subject: [PATCH 08/18] Nicer job names

---
 .github/workflows/ci.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 6f809431..d4037411 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -64,6 +64,7 @@ jobs:
 
 
   test:
+    name: "Test ${{ matrix.python-version }} with ${{ matrix.twisted-version }} Twisted"
     runs-on: ubuntu-20.04
     timeout-minutes: 10
     continue-on-error: ${{ matrix.experimental }}

From 08be5fd0b391c9111eb9fe647e5a4cf9233999b4 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 16:58:21 -0800
Subject: [PATCH 09/18] Add newsfragment

---
 changelog.d/307.removal.rst | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 changelog.d/307.removal.rst

diff --git a/changelog.d/307.removal.rst b/changelog.d/307.removal.rst
new file mode 100644
index 00000000..b82c7bfb
--- /dev/null
+++ b/changelog.d/307.removal.rst
@@ -0,0 +1 @@
+The minimum supported Twisted version has increased to 18.7.0. Older versions are no longer tested in CI.

From 4e5088c5bd8d384a4c8854d87b3df5c148146152 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 16:59:28 -0800
Subject: [PATCH 10/18] Report to coveralls

---
 .github/workflows/ci.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index d4037411..3d89a0f7 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -119,3 +119,7 @@ jobs:
     - run: python -m pip install tox
 
     - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_${{ matrix.twisted-version }}
+
+    - run: python -m pip install coveralls
+
+    - run: coveralls

From 7e6a75c9f730616862b7ad13f7eadda622474fdc Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 17:09:02 -0800
Subject: [PATCH 11/18] Coveralls

https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-gotcha
---
 .github/workflows/ci.yaml | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 3d89a0f7..d394e267 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -123,3 +123,22 @@ jobs:
     - run: python -m pip install coveralls
 
     - run: coveralls
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        COVERALLS_FLAG_NAME: python_${{ matrix.python-version }}-twisted_${{ matrix.twisted-version }}
+        COVERALLS_PARALLEL: true
+
+  # Final step to let Coveralls know all the tests are complete
+  coveralls:
+    needs: test
+    runs-on: ubuntu-20.04
+    steps:
+    - uses: actions/setup-python@v2
+      with:
+        python-version: "3.9"
+
+    - run: python -m pip install coveralls
+
+    - run: coveralls --finish
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

From b15fc7460a2a2490c96e5e71e9ae4803ba514026 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 17:58:23 -0800
Subject: [PATCH 12/18] Add coveralls repo token

As far as I can tell this isn't sensitive? I could create a secret for
it in GitHub, but then it woudn't be available to actions associated
with PRs from forks.
---
 .github/workflows/ci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index d394e267..dd8b18d4 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -125,6 +125,7 @@ jobs:
     - run: coveralls
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        COVERALLS_REPO_TOKEN: 4nctuKHTnVtbdmty2FgdO3iiWm1nb7xc4
         COVERALLS_FLAG_NAME: python_${{ matrix.python-version }}-twisted_${{ matrix.twisted-version }}
         COVERALLS_PARALLEL: true
 
@@ -142,3 +143,4 @@ jobs:
     - run: coveralls --finish
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        COVERALLS_REPO_TOKEN: 4nctuKHTnVtbdmty2FgdO3iiWm1nb7xc4

From 38bc23818adde07d35d3a86ba737056c859b804b Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 18:22:59 -0800
Subject: [PATCH 13/18] Make pypy-3.7 run non-experimental

---
 .github/workflows/ci.yaml | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index dd8b18d4..c5dffdc8 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -70,15 +70,11 @@ jobs:
     continue-on-error: ${{ matrix.experimental }}
     strategy:
       matrix:
-          python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7"]
+          python-version: ["2.7", "3.5", "3.6", "3.7", "3.8", "pypy-2.7", "pypy-3.7"]
           twisted-version: ["lowest", "latest"]
           experimental: [false]
 
           include:
-          - python-version: "pypy-3.7"
-            twisted-version: "latest"
-            experimental: true
-
           - python-version: "3.8"
             twisted-version: "trunk"
             experimental: true

From b7a5a6e5ae234ce954d4a63076da5209836fdb86 Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 18:25:50 -0800
Subject: [PATCH 14/18] Maybe coveralls needs a checkout?

---
 .github/workflows/ci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index c5dffdc8..fb12a5c0 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -130,6 +130,8 @@ jobs:
     needs: test
     runs-on: ubuntu-20.04
     steps:
+    - uses: actions/checkout@v2
+
     - uses: actions/setup-python@v2
       with:
         python-version: "3.9"

From 7ba6fef48f4e9fafee484adb3eebbc4d68de133c Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Tue, 22 Dec 2020 19:21:21 -0800
Subject: [PATCH 15/18] Debugging...

---
 .github/workflows/ci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index fb12a5c0..24fb9598 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -138,7 +138,7 @@ jobs:
 
     - run: python -m pip install coveralls
 
-    - run: coveralls --finish
+    - run: coveralls -v --finish
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         COVERALLS_REPO_TOKEN: 4nctuKHTnVtbdmty2FgdO3iiWm1nb7xc4

From 65a9a24e093ef66cc28e2a084a15262fff521d5f Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Sat, 26 Dec 2020 15:24:11 -0800
Subject: [PATCH 16/18] Remove failing coveralls --finish

---
 .github/workflows/ci.yaml | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 24fb9598..3515458b 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -124,21 +124,3 @@ jobs:
         COVERALLS_REPO_TOKEN: 4nctuKHTnVtbdmty2FgdO3iiWm1nb7xc4
         COVERALLS_FLAG_NAME: python_${{ matrix.python-version }}-twisted_${{ matrix.twisted-version }}
         COVERALLS_PARALLEL: true
-
-  # Final step to let Coveralls know all the tests are complete
-  coveralls:
-    needs: test
-    runs-on: ubuntu-20.04
-    steps:
-    - uses: actions/checkout@v2
-
-    - uses: actions/setup-python@v2
-      with:
-        python-version: "3.9"
-
-    - run: python -m pip install coveralls
-
-    - run: coveralls -v --finish
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        COVERALLS_REPO_TOKEN: 4nctuKHTnVtbdmty2FgdO3iiWm1nb7xc4

From b5e85187dad9b548eb0aaaf8df6bc17e257f97ef Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Sat, 26 Dec 2020 22:55:44 -0800
Subject: [PATCH 17/18] Combine lints to run in parallel

---
 .github/workflows/ci.yaml | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 3515458b..99126c2e 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -29,14 +29,7 @@ jobs:
 
     - run: python -m pip install tox
 
-    - run: tox -q -e flake8
-
-    - run: tox -q -e towncrier
-
-    - run: tox -q -e twine
-
-    - run: tox -q -e check-manifest
-
+    - run: tox -q -p all -e flake8,towncrier,twine,check-manifest
 
   docs:
     runs-on: ubuntu-20.04

From 9d044f53d9c76c71a980414137b27f2171427e9c Mon Sep 17 00:00:00 2001
From: Tom Most <twm@freecog.net>
Date: Sat, 26 Dec 2020 22:56:22 -0800
Subject: [PATCH 18/18] Combine Tox and Coveralls installs

---
 .github/workflows/ci.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 99126c2e..7b9c6b5d 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -105,12 +105,10 @@ jobs:
         factor = table["${{ matrix.python-version }}"]
         print("::set-output name=value::" + factor)
 
-    - run: python -m pip install tox
+    - run: python -m pip install tox coveralls
 
     - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_${{ matrix.twisted-version }}
 
-    - run: python -m pip install coveralls
-
     - run: coveralls
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}