Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version update, release, and push happen in the wrong order in release infrastructure #712

Closed
glyph opened this issue Dec 22, 2023 · 1 comment · Fixed by #767
Closed

version update, release, and push happen in the wrong order in release infrastructure #712

glyph opened this issue Dec 22, 2023 · 1 comment · Fixed by #767
Labels
release-infrastructure

Comments

@glyph
Copy link
Member

glyph commented Dec 22, 2023

release.py builds and uploads to PyPI after committing but before pushing to the branch, meaning that the release is built from a tag which is not a member of any branch, and the merge can easily omit the tag.
@glyph
Copy link
Member Author

glyph commented Dec 22, 2023

see also #711

This was referenced Aug 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 24.8 twisted/klein
1 participant
@glyph