Undefined twilio header causing exception during validation

[mniehe]

Version:
3.30.3

Code Snippet

The function call to Buffer.from() throws an error if passed undefined. When used here, there's no protection from twilioHeader being undefined (which is possible from an invalid request). This is causing exceptions to happen during validation.

function validateRequest(authToken, twilioHeader, url, params) {
  var expectedSignature = getExpectedTwilioSignature(authToken, url, params);
  return scmp(Buffer.from(twilioHeader), Buffer.from(expectedSignature));
}

The easiest fix for this would be to assign a default value if it is undefined:

function validateRequest(authToken, twilioHeader, url, params) {
  twilioHeader = twilioHeader || '';
  var expectedSignature = getExpectedTwilioSignature(authToken, url, params);
  return scmp(Buffer.from(twilioHeader), Buffer.from(expectedSignature));
}

Exception/Log

TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined