[BUG] options.iceServers are being ignored on the new Twilio SDK v1.14

[kamalbennani]

• I have verified that the issue occurs with the latest twilio.js release and is not marked as a known issue in the CHANGELOG.md.
• I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
• I verified that the Quickstart application works in my environment.
• I am not sharing any Personally Identifiable Information (PII)
  or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Actual behavior:

const device = new Device();

device?.setup('TOKEN', {
  // some options,
  iceServers: ['...']
});

It says in the code-base and the previous documentation that this should work but it doesn't.

The reason behind this issue is that on Twilio v1.14, you've introduced a new way of providing the rtcConfiguration here and if the rtcConfiguration is undefined, the options variable will hold a object like this:

const options = Object.assign({ rtcConfiguration: {iceServers: ['..']} }, { rtcConfiguration: undefined })
// which will result into
// => { options: { rtcConfiguration: undefined } }

Of course, a quick solution on our end would be to wrap the iceServers into a rtcConfiguration object or even use the new API, that been said I just wanted to highlight that this bug was introduced on this latest release.

Expected behavior:

iceServers options should not be ignored.

[liberty-rowland]

Thank you @kamalbennani for bringing this up, we're currently investigating this internally and I will update you once we've confirmed and created an internal ticket to address it.