Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Connection.EventName Enum #240

Open
cesaric opened this issue Dec 5, 2020 · 1 comment
Open

[FEATURE] Connection.EventName Enum #240

cesaric opened this issue Dec 5, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@cesaric
Copy link

cesaric commented Dec 5, 2020

Describe the solution you'd like
It would be helpful if we could get a enum for Connection.EventName:

declare namespace Connection {

  enum EventName{
    ACCEPT = 'accept',
    CANCEL = 'cancel',
    DISCONNECT = 'disconnect',
    ERROR = 'error',
    MUTE = 'mute',
    RECONNECTING = 'reconnecting',
    RECONNECTED = 'reconnected',
    REJECT = 'reject',
    RINGING = 'ringing',
    SAMPLE = 'sample',
    VOLUME = 'volume',
    WARNING = 'warning',
    WARNING_CLEARED = 'warning-cleared',
    TRANSPORT_CLOSE = 'transportClose' //This one's in connections.js but I'm not sure if it's relevant.
  }

}

This would be similar to the existing Device.EventName enum.

@cesaric cesaric added the enhancement New feature or request label Dec 5, 2020
@liberty-rowland
Copy link
Contributor

Thanks @cesaric,
I agree these should be enumerated. I've created a ticket internally that we will assign a priority to soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants