fix: fix for failing rpm build #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kridai
commented
Feb 10, 2022
| PATH=$PATH:$PWD/bin eval $(PATH=$PATH:$PWD/bin node -p "require('./package').scripts.postinstall") | ||
|
|
||
| %postun | ||
| rm -f /usr/local/bin/%{name} |
There was a problem hiding this comment.
removing the symlink as part of post uninstall process
| %post | ||
| ln -sf /usr/local/lib/%{name}/bin/%{name} /usr/local/bin/%{name} | ||
| cd /usr/local/lib/%{name} | ||
| PATH=$PATH:$PWD/bin eval $(PATH=$PATH:$PWD/bin node -p "require('./package').scripts.postinstall") |
There was a problem hiding this comment.
running postinstall script defined in package.json
| @@ -6,7 +6,7 @@ RUN npm install && \ | |||
| npm run build && \ | |||
| npm run package | |||
|
|
|||
| FROM centos:latest | |||
| FROM quay.io/centos/centos:stream8 | |||
There was a problem hiding this comment.
update to use centos stream 8, support is there till 2024-05-31
shrutiburman
approved these changes
Feb 10, 2022
sr010
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixed failing RPM build.
centos:latesttag in Dockerfile, This was picking up centos8. Centos has shifted focus towards supporting centos stream. More on this here. Since centos is updating the centos stream image found here. Pulling it in docker fileTesting
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.