feature: Twilio update #278

sr010 · 2021-08-03T12:29:42Z

Closes DII-40
Also contains a minor change for DI754

Screenshot for:

Alert asking the user to update using the 'twilio update' command when a new update is available:
DII-40

Ocif doc: https://oclif.io/docs/releasing.html#autoupdater

Updating using the 'twilio update' command:

(The cli update fails as the installation was npm based. : oclif/plugin-update#49 )

No autoupdate warning when the update fails:

Autoupdate waring for when we install new plugins:
Screenshot for: DI754

Fixes

A short description of what this PR does.

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

sr010 · 2021-08-03T12:34:53Z

src/hooks/plugin-install.js


 const { isTwilioPlugin } = require('../services/plugins');

+const AUTOCOMLETE_INSTALL_WARNING = `If you’re using autocomplete, you’ll need to run ${chalk.bold(


Autocomplete waring for the plugins:install command

sr010 · 2021-08-03T12:35:44Z

src/hooks/prerun/install-prerun.js

+/* eslint-disable no-console */
+const chalk = require('chalk');
+
+const UPDATE_ALERT = `Warning: Use '${chalk.bold('npm update twilio-cli')}' for npm based installations. `;


Adding a new prerun hook to warn users about the update feature not working for npm based installations: oclif/plugin-update#49

kridai

👍

ravali-rimmalapudi · 2021-08-04T12:09:21Z

src/hooks/postrun/plugin-postrun.js

 const AUTOCOMLETE_ALERT = `If you are running bash or zsh on macOS or Linux, you can run one of the two commands below (as appropriate for the shell you are using): \n '${chalk.bold(
  '1) twilio autocomplete bash',
 )}' or \n '${chalk.bold('2) twilio autocomplete zsh')}' `;

 module.exports = async function pluginPostRun(options) {
-  if (options.Command.id === 'plugins:update') {
-    console.warn(chalk.yellowBright(` » ${AUTOCOMLETE_WARNING}`));
+  if (options.Command.id === 'plugins:update' || options.Command.id === 'update') {


[Q] When options.Command.id === 'update' condition will be executed?

This is the 'twilio update' command which I'm adding as part of this pull request. It updates the CLI for us. And once that is done, we need to warn the users about autocomplete as the cache needs to be rebuilt.

Ok, Got it. Thanks.

ravali-rimmalapudi

Looks Good.

shrutiburman

Looks good! 🚀

* chore: Refactor profiles usage to projects (#257) * chore: Store API Keys in Config File (#259) * Save to config and not keytar * Remove secure storage references * Remove keytar load * Remove unnecessary ref to secureStorage * Correct logging * Remove dependent test failures * Add todos * chore: CLI Profile Remove - Check and Use config file before checking system keychain. (#262) * chore: CLI Profile Update - Using config file instead of the system keychain (#264) * chore: CLI Profile Update - Using config file instead of the system keychain * Added the test cases. * Addressed the review comments * Added the missing alignment. * Addressed the review comments * chore: Update profiles list (#265) * chore: Update profiles list * Addressed the comments * chore: Add profiles:port (#266) * Add profiles:port * Eslint fix * Minor edit * update test * Address review comments * Change nomenclature from porting profiles to porting keys * add space * chore: Throw alert when active profile is not set (#267) * Fetching profile by order if active profile is not set 1. Added the warning when active profile is NULL and no environment variable is set in case of profile create/update. 2. Added/updated the corresponding test cases. * Addressed the comments * chore: change post install messaging behaviour (#269) * feat: Added twilio config to list/set edge configuration (#270) * feat: Added twilio config to list/set edge configuration * Added the missing changes * Addressed the review comments. * Updated the missing messages * Updated the review comments. * Moved the common code functionality to utility. * Added the missing change. * Minor refactoring in the getFromEnvironment method. * chore - Updated package.json to point to cli-core release candidate and cli-test new release (#273) * [chore] - Updating package.json to point to cli-core release candidate and cli-test new release * Removed the cli-test version upgrade. * Added the shortform * Updated the cli-core version. * fix: Update release-feature-branch with main (#275) * update slack token * feat: add assets plugin to available plugins (#261) * [Librarian] Regenerated @ 8ec9e610ad617fae257b54113f6d7fa08c457a87 * Release 2.25.0 * chore: updating plugin-help version (#268) Co-authored-by: kridai <[email protected]> * [Librarian] Regenerated @ 7bffdec2c05f6a34b94cebd095be5b1b30705f5d * Release 2.26.0 * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.0 Co-authored-by: Elmer Thomas <[email protected]> Co-authored-by: Phil Nash <[email protected]> Co-authored-by: Twilio <[email protected]> Co-authored-by: kridai <[email protected]> Co-authored-by: kridai <[email protected]> * Updated the cli-core package version with latest. * [Librarian] Regenerated @ 54ad9271a294331f8d036e4a3fc173bb98ecdb82 * Release 2.27.1-rc * chore: Fix autocomplete bugs (#274) Co-authored-by: Shamant Raghav <[email protected]> * feat: add new flag support for config commands to force profile input flag (#272) * feat: add new flag support require-profile-input for config commands * updated tests for config set and list * refactor logic for config set * nit, adding comment * changes per review comment, updating the parsing login for config list command * feature: Twilio update (#278) * SR: Oclif Update changes * SR: adding message to alert about the update * minor change Co-authored-by: Shamant Raghav <[email protected]> Co-authored-by: Anuj Badhwar <[email protected]> Co-authored-by: Elmer Thomas <[email protected]> Co-authored-by: Phil Nash <[email protected]> Co-authored-by: Twilio <[email protected]> Co-authored-by: kridai <[email protected]> Co-authored-by: kridai <[email protected]> Co-authored-by: shamantraghav <[email protected]> Co-authored-by: Shamant Raghav <[email protected]>

## [2.33.0-rc.2](2.33.0-rc.1...2.33.0-rc.2) (2021-11-12) ### Library - Fixes * Hardcoding the name of the first part of the package ([#327](#327)) ([67b44cb](67b44cb)), closes [#313](#313) [#312](#312) [#318](#318) [#289](#289) [#287](#287) [#284](#284) [#286](#286) [#285](#285) [#294](#294) [#295](#295) [#293](#293) [#297](#297) [#298](#298) [#301](#301) [#304](#304) [#310](#310) [#306](#306) [#315](#315) [#316](#316) [#289](#289) [#281](#281) [#298](#298) [#287](#287) [#284](#284) [#304](#304) [#312](#312) [#286](#286) [#285](#285) [#283](#283) [#294](#294) [#285](#285) [#279](#279) [#301](#301) [#280](#280) [#313](#313) [#295](#295) [#293](#293) [#310](#310) [#318](#318) [#297](#297) [#306](#306) [#315](#315) [#316](#316) [#321](#321) * Update release feature branch ([#330](#330)) ([5878348](5878348)), closes [#257](#257) [#259](#259) [#262](#262) [#264](#264) [#265](#265) [#266](#266) [#267](#267) [#269](#269) [#270](#270) [#273](#273) [#275](#275) [#261](#261) [#268](#268) [#274](#274) [#272](#272) [#278](#278) * Updated cli-core version with the latest rc tag. ([abe116e](abe116e))

sr010 added 2 commits August 3, 2021 17:28

SR: Oclif Update changes

85af705

SR: adding message to alert about the update

ff3f4fb

sr010 requested review from ravali-rimmalapudi, Sindhura3, onuzbee, kridai and shrutiburman August 3, 2021 12:29

minor change

549bbd4

sr010 commented Aug 3, 2021

View reviewed changes

kridai approved these changes Aug 3, 2021

View reviewed changes

ravali-rimmalapudi reviewed Aug 4, 2021

View reviewed changes

ravali-rimmalapudi approved these changes Aug 4, 2021

View reviewed changes

shrutiburman approved these changes Aug 12, 2021

View reviewed changes

Sindhura3 merged commit c9c3768 into twilio:release-feature-branch Aug 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Twilio update #278

feature: Twilio update #278

sr010 commented Aug 3, 2021

sr010 Aug 3, 2021

sr010 Aug 3, 2021

kridai left a comment

ravali-rimmalapudi Aug 4, 2021

sr010 Aug 4, 2021

ravali-rimmalapudi Aug 4, 2021

ravali-rimmalapudi left a comment

shrutiburman left a comment •

edited

Loading


		const { isTwilioPlugin } = require('../services/plugins');

		const AUTOCOMLETE_INSTALL_WARNING = `If you’re using autocomplete, you’ll need to run ${chalk.bold(

feature: Twilio update #278

feature: Twilio update #278

Conversation

sr010 commented Aug 3, 2021

Fixes

Checklist

sr010 Aug 3, 2021

Choose a reason for hiding this comment

sr010 Aug 3, 2021

Choose a reason for hiding this comment

kridai left a comment

Choose a reason for hiding this comment

ravali-rimmalapudi Aug 4, 2021

Choose a reason for hiding this comment

sr010 Aug 4, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi Aug 4, 2021

Choose a reason for hiding this comment

ravali-rimmalapudi left a comment

Choose a reason for hiding this comment

shrutiburman left a comment • edited Loading

Choose a reason for hiding this comment

shrutiburman left a comment •

edited

Loading