From b2ce3e5706067152c5f7de9194605c9b248265e2 Mon Sep 17 00:00:00 2001 From: Shubham Date: Thu, 25 Jan 2024 15:50:22 +0530 Subject: [PATCH] chore: upgraded cli-core version and skip healthcheck api (#573) * chore: upgraded cli-core version * chore: skipping healthcheck api * chore: run prettier * chore: add --moit flag in npm install * chore: run make install before audit * chore: removed unused oclif/color dependency * chore: removed node v14 --- .github/workflows/cli-audit.yml | 4 ++-- Makefile | 2 +- package.json | 3 +-- src/hooks/init/twilio-api.js | 1 + 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cli-audit.yml b/.github/workflows/cli-audit.yml index 50c3f54c1..029e9ad0c 100644 --- a/.github/workflows/cli-audit.yml +++ b/.github/workflows/cli-audit.yml @@ -10,18 +10,18 @@ jobs: strategy: fail-fast: false matrix: - node-version: [18.x, 16.x, 14.x] + node-version: [18.x, 16.x] steps: - name: Checkout cli repo uses: actions/checkout@v2 with: fetch-depth: 0 + - run: make install - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} cache: 'npm' - - run: make install - name: Run audit check run: npm audit --audit-level=moderate --production # minimum vulnerability level that will cause the command to fail diff --git a/Makefile b/Makefile index e6e7b3ba2..27af45fac 100644 --- a/Makefile +++ b/Makefile @@ -8,7 +8,7 @@ clean: install: githooks clean rm -f package-lock.json - npm install --no-optional + npm install --omit=optional test: npm test diff --git a/package.json b/package.json index a88062de1..209836096 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,6 @@ "version": "oclif readme && git add README.md" }, "dependencies": { - "@oclif/color": "^1.0.1", "@oclif/core": "^1.16.0", "@oclif/plugin-autocomplete": "^1.3.0", "@oclif/plugin-plugins": "^2.1.0", @@ -43,7 +42,7 @@ "@oclif/plugin-version": "^1.1.1", "@oclif/plugin-warn-if-update-available": "^2.0.2", "@sendgrid/mail": "^8.0.0", - "@twilio/cli-core": "^7.0.0", + "@twilio/cli-core": "^7.19.1", "chalk": "^4.1.2", "file-type": "^16.5.4", "hyperlinker": "1.0.0", diff --git a/src/hooks/init/twilio-api.js b/src/hooks/init/twilio-api.js index 814c7df87..38a598a5c 100644 --- a/src/hooks/init/twilio-api.js +++ b/src/hooks/init/twilio-api.js @@ -61,6 +61,7 @@ class TwilioRestApiPlugin extends Plugin { }; Object.keys(actionDefinition.domain.paths).forEach((pathName) => { + if (pathName === '/healthcheck') return; const versionName = pathName.split('/')[1]; const shortVersion = versionName.replace(/v/g, '');