Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Summary has been deprecated #1623

Closed
itohatweb opened this issue Mar 22, 2022 · 0 comments
Closed

Application Summary has been deprecated #1623

itohatweb opened this issue Mar 22, 2022 · 0 comments
Assignees
@itohatweb
Labels
c-model Affects the model crate d-api Change related to Discord's API. d-breaking Code breaks the API because of Discord d-not-deployed Discord API change that hasn't been deployed to the docs.

Comments

@itohatweb
Copy link
Member

itohatweb commented Mar 22, 2022 •
edited
Loading

The application summary is part of selling applications on Discord. Since this feature has now been removed it's now an empty string. We can remove that property from IntegrationApplication and CurrentApplicationInfo now.

Edit: Looks like summary has not been removed from IntegrationApplication. I asked on the dapi server whether this was an oversight.

Reference: discord/discord-api-docs#4668

Edit: Waiting for discord/discord-api-docs#4686 to get merged
@itohatweb itohatweb added c-model Affects the model crate d-api Change related to Discord's API. d-breaking Code breaks the API because of Discord labels Mar 22, 2022
@itohatweb itohatweb self-assigned this Mar 22, 2022
@itohatweb itohatweb added the d-not-deployed Discord API change that hasn't been deployed to the docs. label Mar 27, 2022
@itohatweb itohatweb mentioned this issue Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itohatweb itohatweb

Labels
c-model Affects the model crate d-api Change related to Discord's API. d-breaking Code breaks the API because of Discord d-not-deployed Discord API change that hasn't been deployed to the docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(model)!: remove IntegrationApplication summary twilight-rs/twilight
1 participant
@itohatweb