Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date parsing with timezones #765

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

plepe
Copy link
Contributor

@plepe plepe commented Dec 11, 2020

This pull request adds tests for dates with timezone information, e.g.: 1995-12-17T08:24:00Z, 1995-12-17T08:24:00+02:00. The version with Z currently does not work. The problem is the strtodate function of locutus, which currently can't handle these strings (it has been fixed though, but not released yet).

Pull request which should eventually solve #726. Waiting for locutus release which incorporates locutusjs/locutus#432. I will update the pull request as soon as this release is available.

@willrowe
Copy link
Collaborator

The bug in https://github.com/locutusjs/locutus was fixed and released in v2.0.15.

The dependency has been bumped up to v2.0.15 in #790 and should be released in v1.16.0.

These tests are useful to prevent regression, so I'm going to go ahead and merge them for release in v1.16.0 as well.

@willrowe willrowe marked this pull request as ready for review June 28, 2022 19:14
@willrowe willrowe closed this Jun 28, 2022
@willrowe willrowe reopened this Jun 28, 2022
@willrowe willrowe merged commit c751016 into twigjs:master Jun 28, 2022
@plepe plepe deleted the date-timezone-handling branch July 15, 2022 11:06
RobLoach added a commit that referenced this pull request Feb 28, 2023
Major improvements:
* Fix passing context around by @willrowe in #850
* Add namespace support to `source` function by @willrowe in #823
* Use src/twig.js as package's main script instead of the compiled twig.js by @RobLoach in #829

Minor improvements:
* Fix macro changing context in loop by @mihkeleidast in #773
* Imported function PATHS.strip_slash() missing by @murageyun in #770
* Convert non-string values to string before replacing by @kmonahan in #797
* Add GitHub actions test workflow by @willrowe in #817
* Fix date parsing with timezones by @plepe in #765
* Fixed Twig official's URL on README.md by @Geolim4 in #822
* Add tests for whitespace in paths by @willrowe in #824
* Fix multiple includes with embeds by @willrowe in #828
* Update to Mocha 9.x by @RobLoach in #831
* Add test for issue #767 by @willrowe in #837
* Add support for `divisible by` test by @willrowe in #838
* Add support for `with` tag without context or `only` keyword by @willrowe in #839
* Use v3 of `actions/checkout` by @willrowe in #846
* Test on more node versions by @willrowe in #847
* Fix webpack 5 compatibility by @willrowe in #849
* Add test to confirm `renderFile` error handling by @willrowe in #851
* Fix casing of variables in docs by @willrowe in #852
* Bumped dependencies by @dependabot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants