Nickel: formatting of single-line annotated let #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were formatting a let-binding followed by a single-line annotation and some content by always putting the `=` sign and the following content on a new line, indenting the content one level to the right. This was mostly due to a limitation of Topiary around scopes. Today, this limitation has been lifted thanks to the introduction of measuring scopes. We make use of the latter to finally format such let-bindings (and bindings in general) as we originally wanted (see #743).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect formatting of single-line annotated let in Nickel
Issue: #743
Description
Previously, we were formatting a let-binding followed by a single-line annotation and some content by always putting the
=sign and the following content on a new line, indenting the content one level to the right.This was mostly due to a limitation of Topiary around scopes. Today, this limitation has been lifted thanks to the introduction of measuring scopes. We make use of the latter to finally format such let-bindings (and bindings in general) as we originally wanted in #743.
Checklist
Checklist before merging: