Introduce measuring scopes #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbacquey
force-pushed
the
nb/measuring_scopes
branch
from
ce47691 to
f11d653
Compare
aspiwack
reviewed
Oct 1, 2024
nbacquey
force-pushed
the
nb/measuring_scopes
branch
3 times, most recently
from
2c4edb0 to
f411f24
Compare
Xophmeister
reviewed
Oct 1, 2024
Xophmeister
approved these changes
Oct 1, 2024
nbacquey
force-pushed
the
nb/measuring_scopes
branch
from
b2c3ee7 to
55cc175
Compare
This commit introduce the notion of "measuring scope", which works in conjonction with "regular" custom scopes, to bind the multi-line-ness of the latter to a smaller subsection of itself.
This commit uses the newly introduced "measuring scopes" to fix the indentation setback introduced in #745.
nbacquey
force-pushed
the
nb/measuring_scopes
branch
from
55cc175 to
d2cc542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature in Topiary: measuring scopes.
They work in conjunction with "regular" custom scopes, to bind the multi-line-ness of the latter to a smaller subsection of itself.
Additionally, this PR solves a regression in OCaml introduced in #745, that couldn't be fixed without measuring scopes.
See the updated README for the precise usage of those measuring scopes.
Checklist
Checklist before merging: