Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nickel inconsistent formatting of annotated let-bindings #744

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

yannham
Copy link
Member

@yannham yannham commented Sep 17, 2024

Nickel formatting of annotated let-bindings

Closes #743

Description

This is a tentative fix of #743, but I have yet to figure out how to properly handle the indentation part.

Checklist

Checklist before merging:

  • CHANGELOG.md updated
  • README.md up-to-date

@ErinvanderVeen ErinvanderVeen marked this pull request as draft September 18, 2024 09:35
@yannham yannham force-pushed the nickel/fix-multiline-let branch from dbc5dce to 3f0eaf6 Compare September 19, 2024 12:47
This commit fixes some indentation issue with annotated let-bindings
(#743). All the proposals of said
issue couldn't be implemented in current Topiary, so this only takes
care of the `in` placement. This commit refactors a bit the associated
queries and tries to improve documentation.
@yannham yannham force-pushed the nickel/fix-multiline-let branch from 5bcb061 to bdfb683 Compare September 19, 2024 12:50
@yannham yannham marked this pull request as ready for review September 19, 2024 12:50
@yannham yannham requested a review from nbacquey September 19, 2024 12:50
@yannham yannham merged commit 7229c0f into main Sep 20, 2024
9 checks passed
@yannham yannham deleted the nickel/fix-multiline-let branch September 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent placement of in depending on the term being annotated
2 participants