Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nickel tree-sitter grammar #490

Merged
merged 2 commits into from
May 30, 2023
Merged

Bump nickel tree-sitter grammar #490

merged 2 commits into from
May 30, 2023

Conversation

nbacquey
Copy link
Member

Closes #485

Xophmeister
Xophmeister approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would recommend also bumping the Nickel WASM binary to match in this PR.

@nbacquey
Copy link
Member Author

I'm not sure which steps to take to do that ; the instructions in CONTRIBUTING.md are unclear. Would you mind updating them and/or bumping the binary yourself?

@nbacquey nbacquey merged commit 84da13f into main May 30, 2023
@nbacquey nbacquey deleted the nb/fix_nickel branch May 30, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xophmeister Xophmeister Xophmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse error in Nickel files with wildcard type annotations
2 participants
@nbacquey @Xophmeister