Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut down on flake input dependencies #613

Open
toastal opened this issue Sep 6, 2023 · 1 comment
Open

Cut down on flake input dependencies #613

toastal opened this issue Sep 6, 2023 · 1 comment
Assignees
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter P2 major: an upcoming release

Comments

@toastal
Copy link
Contributor

toastal commented Sep 6, 2023

Is your feature request related to a problem? Please describe.
When I include this flake as an input, I get a number of dependencies that I now have to manage. I don’t think these are necessary: numtide:flake-utils, numtide:nix-filter and can be inlined for less code than the import+usage+flake.lock lines. The default systems should be nixpkgs.lib.systems.flakeExposed & flake-utils doesn’t include some of these systems.

Describe the solution you'd like
Inline the for loop from flake-utils. Use builtins.path { path = …; filter = path: type: …; } to replace nix-filter or use lib.fileset.

Describe alternatives you've considered
tolerating the dependency tree exploding as each input necessitates different versions with flakes

Additional context

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@ErinvanderVeen ErinvanderVeen self-assigned this Sep 7, 2023
@ErinvanderVeen ErinvanderVeen added the P2 major: an upcoming release label Sep 7, 2023
@ErinvanderVeen ErinvanderVeen added the epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter label Sep 28, 2023
@toastal
Copy link
Contributor Author

toastal commented Nov 18, 2024

This is still affecting me. As Tweag isn’t maintaining upstream in Nixpkgs, the easiest way to get Topiary is to add it to an input, but there are a lot of unneeded dependencies which is not a good UX for using this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter P2 major: an upcoming release
Projects
None yet
Development

No branches or pull requests

2 participants