Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the setting of the collation mode in the configuration file #612

Closed
Xophmeister opened this issue Sep 6, 2023 · 2 comments · Fixed by #790
Closed

Allow the setting of the collation mode in the configuration file #612

Xophmeister opened this issue Sep 6, 2023 · 2 comments · Fixed by #790
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter type: feature request

Comments

@Xophmeister
Copy link
Member

This discussion makes the point that it may be beneficial to be able to set the collation mode in the configuration file in certain contexts. For example, a project-specific configuration may want to override all configuration for the sake of reproducibility.

(Note: This issue depends on #583)
@Xophmeister Xophmeister mentioned this issue Sep 6, 2023
Merged
26 tasks
@ErinvanderVeen
Copy link
Collaborator

How would one collate the collation mode?

@Xophmeister
Copy link
Member Author

Xophmeister commented Sep 7, 2023 •
edited
Loading

As it's just a string, I would simply take its value from the highest priority config source (as with other strings), unless overridden by the CLI flag/envvar.

@ErinvanderVeen ErinvanderVeen added the epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter label Sep 28, 2023
@nbacquey nbacquey mentioned this issue Nov 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No longer merge config files by default, use priorities instead tweag/topiary
2 participants
@Xophmeister @ErinvanderVeen