Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document or automate the update process for WASM binaries #495

Closed
nbacquey opened this issue Jun 1, 2023 · 2 comments
Closed

Document or automate the update process for WASM binaries #495

nbacquey opened this issue Jun 1, 2023 · 2 comments
Labels
P2 major: an upcoming release type: feature request

Comments

@nbacquey
Copy link
Member

nbacquey commented Jun 1, 2023

When writing #494, I once again found myself unable to update the WASM grammar for OCaml, despite the instructions in CONTRIBUTING.md. I struggled with Docker configurations, manual ad hoc copy/pastes, and achieved nothing in the end.

I think we need to either automate the process, or make it fool-proof.

@Xophmeister
Copy link
Member

I struggled with Docker configurations

I think the process launches a container, rather than you having to run everything inside a container.

That said, I agree: it took a while to work out, the first time I did it. Having it part of the CI build would be ideal, if it can be triggered only when the dependency changes.

@ErinvanderVeen ErinvanderVeen added the P2 major: an upcoming release label Jun 14, 2023
@ErinvanderVeen
Copy link
Collaborator

Resolved with #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 major: an upcoming release type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants