Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the hermeticity heuristic #84

Closed
guibou opened this issue Jun 17, 2019 · 0 comments · Fixed by #86
Closed

Rework the hermeticity heuristic #84

guibou opened this issue Jun 17, 2019 · 0 comments · Fixed by #86

Comments

@guibou
Copy link
Contributor

guibou commented Jun 17, 2019

In #82 we discussed the fact that the hermeticity heuristic implemented in nixpkgs_package is too complicated.

The current implementation parses the output of nix-build -vv and tries to detect references to files which are not listed in nix_file_deps. This parsing is fragile and complicated.

@mboes proposed during the #82 discussion to replace this code by a simple copy (symlink) of all the files listed in nix_file_deps in another temporary workspace in which the nix-build will be executed. This solution does not track dependencies on absolute path, but it way simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant