Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Implement testing for the browser target #272

Open
TerrorJack opened this issue Sep 11, 2019 · 1 comment
Open

Implement testing for the browser target #272

TerrorJack opened this issue Sep 11, 2019 · 1 comment
Labels
P1 critical: next release type: feature request

Comments

@TerrorJack
Copy link
Member

Our CI config only tests the compiled code for the node target; linking is tested for browser target, but the output code is not run, therefore regressions in the browser target can be introduced without notice. We should run all tests which don't require node-specific imports on the browser target as well. A good first step would be to implement selenium or puppeteer based logic in inline-js for running code in a headless browser.

@TerrorJack TerrorJack added P2 major: an upcoming release type: feature request labels Sep 11, 2019
@TerrorJack
Copy link
Member Author

Some recent updates about the issue:

  • Besides the in-tree todomvc, it would be nice to test plzwrk and future user-written frameworks as well. It would be a nice way to prevent (or at least notify) downstream breakage.
  • Microsoft has added playwright to the headless testing framework landscape. It has a puppeteer-like modern API, but works with chromium/firefox/webkit. This should be preferred when we actually starting working on this issue.

@TerrorJack TerrorJack added P1 critical: next release and removed P2 major: an upcoming release labels May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 critical: next release type: feature request
Projects
None yet
Development

No branches or pull requests

1 participant