From 392c3ed55de72856bcfb383ba661b0510a8dcf0a Mon Sep 17 00:00:00 2001 From: Hannah Issermann Date: Tue, 7 Mar 2023 11:44:26 +0100 Subject: [PATCH 1/2] Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples --- site/layouts/shortcodes/js-dismiss.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/site/layouts/shortcodes/js-dismiss.html b/site/layouts/shortcodes/js-dismiss.html index 45d72d0eb28c..0bd93b95322d 100644 --- a/site/layouts/shortcodes/js-dismiss.html +++ b/site/layouts/shortcodes/js-dismiss.html @@ -2,14 +2,14 @@ {{- $name := .Get 0 -}} -Dismissal can be achieved with the `data` attribute on a button **within the {{ $name }}** as demonstrated below: +Dismissal can be achieved with the `data-bs-dismiss` attribute on a button **within the {{ $name }}** as demonstrated below: ```html ``` -or on a button **outside the {{ $name }}** using the `data-bs-target` as demonstrated below: +or on a button **outside the {{ $name }}** using the additional `data-bs-target` as demonstrated below: ```html - + ``` From 51058a3e20d0d9acbe88c0a51f89755496c0720d Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Fri, 10 Mar 2023 11:23:23 -0600 Subject: [PATCH 2/2] Update site/layouts/shortcodes/js-dismiss.html MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Julien Déramond --- site/layouts/shortcodes/js-dismiss.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/layouts/shortcodes/js-dismiss.html b/site/layouts/shortcodes/js-dismiss.html index 0bd93b95322d..3d0c27883fc0 100644 --- a/site/layouts/shortcodes/js-dismiss.html +++ b/site/layouts/shortcodes/js-dismiss.html @@ -11,5 +11,5 @@ or on a button **outside the {{ $name }}** using the additional `data-bs-target` as demonstrated below: ```html - + ```