Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary .fill child for .topbar? #97

Closed
karthikv opened this issue Aug 26, 2011 · 2 comments
Closed

Unnecessary .fill child for .topbar? #97

karthikv opened this issue Aug 26, 2011 · 2 comments
Milestone

Comments

@karthikv
Copy link
Contributor

As per a comment in patterns.less, the .fill element is in place because "overflow visible is not honored by IE when filter is present" (https://github.com/twitter/bootstrap/blob/master/lib/patterns.less#L19). This comment no longer seems to apply, though, as no filters remain in both .topbar and .fill. Consequently, can this extra element be removed by applying its styles directly to .topbar? The code I'm referring to is included below for ease of reference:

.topbar {
  height: 40px;
  position: fixed;
  top: 0;
  left: 0;
  right: 0;
  z-index: 10000;
  overflow: visible;

  // gradient is applied to it's own element because overflow visible is not honored by ie when filter is present
  .fill {
    background:#222;
    #gradient > .vertical(#333, #222);
    @shadow: 0 1px 3px rgba(0,0,0,.25), inset 0 -1px 0 rgba(0,0,0,.1);
    .box-shadow(@shadow);
  }

  // [omitted code]
}
@mdo
Copy link
Member

mdo commented Aug 26, 2011

I think the original plan was to bring back the ms filters, at least for IE9 pehaps. There are numerous rendering problems associated with that (clickability, how IE handles hex codes, rounded corners with gradients, etc). Definitely something to check out.

@karthikv
Copy link
Contributor Author

Ah, I understand. I'll look into it and see what I can do. As this is now digressing into a different problem, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants