Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offcanvas don't remove events on dispose (trigger js error on document click) #33535

Closed
markusilmer opened this issue Mar 31, 2021 · 1 comment · Fixed by #33545
Closed

offcanvas don't remove events on dispose (trigger js error on document click) #33535

markusilmer opened this issue Mar 31, 2021 · 1 comment · Fixed by #33545
Assignees
@GeoSot
Labels
confirmed js v5

Comments

@markusilmer
Copy link

I create and destroy (use dispose()) Offcanvas with JS. After destroy i get JS errors on every click

Here is a simple Codepen example
https://codepen.io/maz1989/pen/abppYVL
@GeoSot
Copy link
Member

GeoSot commented Apr 9, 2021 •
edited by alpadev
Loading

Will be fixed with #33545

Demo codepen

@GeoSot GeoSot self-assigned this Apr 10, 2021
@GeoSot GeoSot mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeoSot GeoSot

Labels
confirmed js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the backdrop util in offcanvas, enforcing consistency twbs/bootstrap
2 participants
@markusilmer @GeoSot