Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default border radius value to all border radius mixins #31515

Closed
jeremyvii opened this issue Aug 20, 2020 · 1 comment
Closed

Add a default border radius value to all border radius mixins #31515

jeremyvii opened this issue Aug 20, 2020 · 1 comment
Labels

Comments

@jeremyvii
Copy link
Contributor

It would be convenient if the $border-radius variable was the default value for all border radius mixins, like it is for border-radius(). That way you could include mixins, such as border-top-radius(), without providing a parameter.

I believe this would be an easy change and would be happy to open a PR. However, I wanted to make sure there wasn't a reason why there isn't already a default parameter for these mixins.

Before proposal

.item {
  @include border-top-radius($border-radius);
}

After proposal

.item {
  @include border-top-radius();
}
@jeremyvii
Copy link
Contributor Author

Closing since #31571 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant