Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masonry-ish grid #28076

Closed
MartijnCuppens opened this issue Jan 17, 2019 · 6 comments · Fixed by #28922
Closed

Masonry-ish grid #28076

MartijnCuppens opened this issue Jan 17, 2019 · 6 comments · Fixed by #28922
Labels

Comments

@MartijnCuppens
Copy link
Member

Follow-up on https://twitter.com/getbootstrap/status/1083797119742267392

Maybe we should just add a masonry-ish css grid? We currently only have the card columns, but we might just provide a card independant implementation with responsive classes?

@mdo
Copy link
Member

mdo commented Jan 18, 2019

Definitely down to explore!

@MartijnCuppens
Copy link
Member Author

I'm afraid this will just lead to more issues like #28676. Maybe some day we 'll have better web standards to deal with this, until then manonry will be the tool to use.

We currently still have the card groups, but to honest, that's not really a bulletproof solution for this layout and it still lacks some flexibility (determine how many columns should be used and control over responsive breakpoints).

Should we ditch the card decks, change our demo to a masonry example or just add a clearer warning about its limits?

cc @twbs/css-review

@mdo
Copy link
Member

mdo commented May 1, 2019

Best implementation I’ve seen so far, but haven’t dived into yet, is this: https://tobiasahlin.com/blog/masonry-with-css/. Unsure if or how we could make that generalized for enough people and projects.

@MartijnCuppens
Copy link
Member Author

Saw that, but if you look to it more in detail you'll see this is a way uglier that the columns solution we have now, it uses a fixed container height and doesn't take height into account.

@mdo
Copy link
Member

mdo commented May 1, 2019

Yeah, it’s not without trade offs. Might make most sense to build an example with Masonry and Cards, and how you can move from our CSS columns to Masonry.

@vinoduxid
Copy link

Any help on this #28921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants