-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support close button smaller size (or support close button that can be used inside badge) #26669
Comments
I was under the impression that a badge was something to promote, like this is a NEW site, feature, or branding, possibly new release.. Why would you want to dismiss the badge? |
@ahtee may be you miss that I'm talkin about Inside codepen there was another sample : https://dashboardcode.github.io/BsMultiSelect/ It would be good to have BS flexible enough to build multiselect plugins without CSS, only using classes (and js). Actually BS is close to it. "close button inside badge" is most "strange" requirement, other three are just small improvements Of course plugin works right now, and when you copy its SCSS https://github.com/DashboardCode/BsMultiSelect/blob/master/scss/BsMultiSelect.scss to you your project "adaptation to the BS theme" will be automatic (I hope), since scss use BS variables but still it would be so nice to have such complex plugin runned only on "bs classes" and without need of CSS or SCSS. Just four little (and natural) additions and it become possible. |
ah now I see what you mean. thanks for explaining for me and for anyone else who may wonder the same |
@ahtee , thank you for your interest |
If you're using FontAwesome, you can use the (in my opinion) superior "X" icon which scales better. |
@Joyrex "X button" depends on current theme and this is good. see how nice it works with bootswatch sketchy theme: There are no code that style close button font there. I get it from theme and it works. (And I would like to have the same beaty with button size and aligment. |
@rpokrovskij please can you update to our v4.1.1 release ? |
@Johann-S if you talking about codepen - done |
Should come with #26823 for badges. |
That is how close button looks inside badge:
https://codepen.io/rpokrovskij/pen/YvWPQG
there are no standard way to change size, verticaly align and inverse color. I propose to add a standard support of close button inside badge case or add standard classes to allow users manipulate close button.
The text was updated successfully, but these errors were encountered: