Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split button dropup/ right/ left carets are misaligned #25718

Closed
ysds opened this issue Feb 26, 2018 · 2 comments
Closed

Split button dropup/ right/ left carets are misaligned #25718

ysds opened this issue Feb 26, 2018 · 2 comments
Labels
css has-pr v4

Comments

@ysds
Copy link
Member

ysds commented Feb 26, 2018 •
edited
Loading

Dropdown is OK, but dropup / right / left carets seems to be misaligned.

image

Demo: https://codepen.io/anon/pen/oEapLg

Docs: http://getbootstrap.com/docs/4.0/components/dropdowns/#dropup-variation
@ysds ysds mentioned this issue Feb 26, 2018
Merged
@ysds ysds changed the title Single button dropup/ right/ left carets are misaligned Split button dropup/ right/ left carets are misaligned Feb 26, 2018
@alecpl
Copy link
Contributor

alecpl commented Feb 26, 2018

All these :after elements should use vertical-align:middle.

@ysds
Copy link
Member Author

ysds commented Feb 26, 2018 •
edited
Loading

@alecpl My point is horizontal alignment. The current CSS seems to have lack of alignment overwrite of horizontal direction. I have already created a PR #25719 to fix this.

@mdo mdo added the has-pr label Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdo @alecpl @Johann-S @ysds