Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the principle of a design, background-color and foreground-color is important. #25383

Closed
xiuno opened this issue Jan 20, 2018 · 1 comment
Labels

Comments

@xiuno
Copy link

xiuno commented Jan 20, 2018

Most Compnent shoud caculate from the $background-color and $foreground-color.

$background-color: #111;
$foreground-color: #eee;

$grey-100: lighten($background-color, 90%); 
$grey-200: lighten($background-color, 80%);
$grey-200: lighten($background-color, 70%);

just like this, and component background should use use the value of calculating $background-color.
because:The atmosphere of the page is often expanded around the background color.

When I made the darkened theme, we can see that the default value of BS4 design principle is not reasonable:
image

@MartijnCuppens
Copy link
Member

Our color utilities can be used to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants