Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btn-outline.active box shadows #25135

Closed
mudrz opened this issue Dec 30, 2017 · 1 comment
Closed

btn-outline.active box shadows #25135

mudrz opened this issue Dec 30, 2017 · 1 comment

Comments

@mudrz
Copy link

mudrz commented Dec 30, 2017

Bootstrap 4 beta 3

Related to active buttons issue
@ysds
#24760
Related pull request
@mdo
#25070

I agree to remove the focus box shadow from .active.

The focus outline(box shadow) should only be used to highlight the focused elements - only one >element per window has the focus at a time.

In beta 3 the .active box shadow button issue was fixed for regular buttons, but not for outline buttons.
Additionally active outline buttons no longer change their text color when active
https://codepen.io/anon/pen/vpmZZM?editors=1000#0

@719media
Copy link
Contributor

719media commented Dec 30, 2017

I'm not sure if @mudrz is saying that the btn-outline-* buttons' :active state should have a different text color, but I think he is... and I agree. I think having color: color-yiq($color-hover); on the :active looks "wrong" in that the dark text just seems out of place. It should be a lighter color like the hover (color: color-yiq($color);) IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants