Why do you have to redeclare the whole SASS Map?

[ghost]

Why do you have to redeclare the whole SASS Map when you re-map the variables?

I can't complete a build if I do this partially, I have to redeclare everything to make it work :(

[bardiharborow]

I assume you're referring to the maps added in #23260. The whole point is that you shouldn't have to redeclare the whole map, so if that's what's happening to you, can you share your code and what sass version you're using, and we'll try and figure out what's going on.

[ghost]

Yeah so basically, for example I'd like orange to be the primary color

// Custom Variables
$theme-colors: (
  primary: $orange,
  secondary: $gray-600,
  success: $green,
  info: $cyan,
  warning: $yellow,
  danger: $red,
  light: $gray-100,
  dark: $gray-800
);

// Import all of bootstrap
@import 'bootstrap';

You get an error at compilation as the color variable names aren’t already defined. I am using Sass 3.4.23 (Selective Steve).

So I guess the question would be how do you add/amend/remove from the $theme-colors sass map?

[pat270]

The color variable names aren't defined because Sass parses top down. The color variables are defined in the bootstrap import, either copy all the color variables above $theme-colors or just set:

$theme-colors: ( primary: #fd7e14 );

[mdo]

Demo I provided shows the map merging in action: https://codepen.io/emdeoh/pen/qXxYEO. Could be a Sass version issue?

[mdo]

Closing since this was resolved in our codebase.

[ghost]

So you are basically saying just redefine your entire theme-colors stack… That is an unusual way to do it :(

[mdo]

No, I'm saying we fixed this issue since our beta in our v4-dev branch. Pull the latest and try that with your Sass compiler. If it doesn't work still, see if there's a difference in the Sass compilers and we can go from there.

[ghost]

Ah, I misunderstood, my apologise, I will try that now ;) Thank you for listening