-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropdown-menu-right no longer works #23479
Comments
ref: #23308 |
I am able to work around it in my code by elevating this snippet from /_navbar.scss:
... to a global level in my scss |
I struggled with it recently as well. It only works if a navbar-toggleable-* class is used. Not sure if it's the way it should be. |
The preview of your code as expired in JSBin maybe can you create a Codepen to see what's your bug |
Preview is expired? Not sure what you mean. I can access it fine from an incognito window. |
Here is the same as a codepen: |
thanks @froodley 👍 |
this is similar to #23429 , which I believe to be a result of https://github.com/twbs/bootstrap/blob/v4-dev/js/src/dropdown.js#L269 this part of dropdown.js. I cannot understand the thinking behind the referenced function, can someone please clarify? |
We made the choice to disable Popper.js style for Dropdowns in navbar here : #22782 |
I don't understand then how we are meant to have right-aligned dropdowns inside of navbars? Is this a feature we are meant to be implementing ourselves? I feel as though this is an important part of many navigations. |
As it wrote in our documentation when you use Dropdown in a navbar you should have a So in your CodePen add |
Then you should change the documentation in https://getbootstrap.com/docs/4.0/components/dropdowns/#menu-alignment because there is written
Allowing Still a issue in my eyes |
That's a bit different here if you want to use |
I think @JavanXD is referring to the fact that although this is in the code, it is not textually called out as being an important detail. I myself was not previously using the nav because I only had one item in the |
I agree, was not clear from the docs, but thanks for the fix! |
The docs need to provide more clarification about drop down button placement inside a navbar, especially if you want to have the dropdown on the right side of the page inside a navbar. |
I have reproduced the problem with .dropdown-menu-right under 4.0beta here:
(Issue is the dropdown menu does not go to {right: 0;left: auto}, so basically the class does nothing, menu is left aligned, at this point for some people)
https://jsbin.com/qemicohayu/edit?html,output
The text was updated successfully, but these errors were encountered: