-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips Disable Scrolling in Modals #23222
Comments
Confirmed with our last dist files : https://codepen.io/Johann-S/pen/yoVKMp?editors=1010#0 |
is it the same case with popper.js ? as i see the example use tether.js ? |
Mine use Popper.js @jipexu 😉 |
ok |
adding |
@gijsbotje Unsupported in IE10 though, see https://caniuse.com/#feat=pointer-events (click "Show all") (maybe a reason for dropping support for it, as discussed e.g. in #21416). |
@Herst don't confuse Pointer Events (the JS API) with |
@patrickhlauke I know that and I meant the CSS property and linked to the correct one, maybe I should have mentioned it. |
as editor of the pointer events spec i'm aware of Apple's political position on the matter ;) |
What's the problem here?
Some possible solutions:
As there are several possible solutions, I did not want to work on this and instead put it to consideration. |
Good catch @lucascono ! 👍 using and my updated CodePen : https://codepen.io/Johann-S/pen/yoVKMp?editors=1010 Should we add a special mention in our documentation ? /CC @patrickhlauke , @mdo, @XhmikosR |
My main concern about SVGs is that this is non-standard. (Remember the other day on Slack I mentioned it) I wonder what's the reasoning for not supporting SVGs with a title attribute in the root element. |
I thought the same as @XhmikosR. In my opinion, option 1 seems the best. I had entered the visual test to prove just that option, but casually I found the SVG element. And then I decided to pause my work. Putting the tooltips at the same level as your triggers would greatly facilitate the development, perhaps avoid future issues, and allow the operation with other external libraries. And implementing it is relatively simple: And I find it more usual to place a tooltip within a modal than within an SVG. |
For now we will leave that like that, folks can use |
Hella old issue, but in checking the linked CodePen from @Johann-S I don't see broken scrolling. Page scrolls fine before the tooltips are shown, and while they're shown. Closing as possibly fixed. |
When tooltips are in a modal (triggered manually so they are constantly displayed) and the modal requires scrolling, when the cursor is over a tooltip, scrolling is disabled.
Fiddle here: https://jsfiddle.net/christianklemp_imt/2w7v77e5/
Running in Google Chrome (v60.0.3112.90) on macOS sierra (v10.12.6)
The text was updated successfully, but these errors were encountered: