Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog width - media rule #22668

Closed
matejlednar opened this issue May 20, 2017 · 2 comments
Closed

Dialog width - media rule #22668

matejlednar opened this issue May 20, 2017 · 2 comments
Labels

Comments

@matejlednar
Copy link

matejlednar commented May 20, 2017

Current CSS
@media (min-width: 576px)
.modal-dialog {
max-width: 500px;
margin: 30px auto;
}

Dialog's width is too small on bigger screens.

Maybe it should be:

@media (max-width: 576px)
.modal-dialog {
max-width: 500px;
margin: 30px auto;
}

similar problem with form-group

@mdo
Copy link
Member

mdo commented May 25, 2017

Those sizes are correct. They were changed in #21207.

@mdo mdo closed this as completed May 25, 2017
@bakasmarius
Copy link

The problem is not with the sizes themselves, but rather applying css from a certain size:
@media (min-width)
instead of to a certain size:
@media (max-width)

I currently have an issue where the CSS below gets applied to a modal on a screen which is 1920px wide and if change the CSS from min to max in Chrome DevTools, everything works as expected

@media (min-width: 576px)
.modal-dialog {
  max-width: 500px;
  margin: 30px auto;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants