Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the spacing utility to allow for responsive breakpoints like "pl-lg-3" #22134

Closed
arechsteiner opened this issue Mar 8, 2017 · 2 comments

Comments

@arechsteiner
Copy link
Contributor

I don't know if this has been discussed yet, I could not find any issue except for #21943 which suggests the same thing for sizing helpers.

I would consider adding responsive capabilities to the spacing utilities as well. This is the issue I run into the most when using Bootstrap 4. I try to use one of the spacing utilities, say pl-3 but then I end up removing it again because the padding actually hurts on other view port sizes.

Here's an example from my current project:

spacing-1
spacing-2

As you see, the spacing tools end up being inappropriate for this case, because I only need the spacing on certain screen sizes. This happens in many other cases, possibly even in most cases when spacing utilities would come in handy.

I'm not sure if this is a feasible feature to implement. I could imagine code bloat and more complex code as a potential showstopper. Nonetheless I thought it would be good to at least consider this.

Examples:

pl-1, pl-sm-1, pl-md-1, pl-lg-1
mx-3, mx-sm-3, mx-md-3
m-51, m-lg-5

@iatek
Copy link
Contributor

iatek commented Mar 8, 2017

I think this has already been implemented and merged...

#20926

@arechsteiner
Copy link
Contributor Author

Oh wow, yeah that's exactly it, and it's even implemented and usable with the current alpha. I just never thought to actually try that, since it is not yet documented. Thanks a lot, today my life got a little bit easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants