Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel slide animation bounces slightly on completion [iOS9/Safari] #21751

Closed
henwen opened this issue Jan 16, 2017 · 3 comments
Closed

Carousel slide animation bounces slightly on completion [iOS9/Safari] #21751

henwen opened this issue Jan 16, 2017 · 3 comments
Labels

Comments

@henwen
Copy link

henwen commented Jan 16, 2017

This is new behavior on Alpha 6 –

On completion of the slide animation, the carousel-item content has a small horizontal bounce on the left edge of the carousel. It's a bit hard to see in the gif below, so visit the docs on an iOS device if you have one for a clearer example.

farflungfondflyingfish

This behavior is only on iOS9 Safari (as far I know) and is likely related to whatever's causing issues #21749 and #21750.

@henwen henwen changed the title Carousel slide animation blurry on completion [iOS9/Safari] Carousel slide animation bounces slightly on completion [iOS9/Safari] Jan 16, 2017
@edoparearyee
Copy link

I had this issue as well. I think this is probably down to the below:

If the browser doesn't support transition events then the javascript logic for this component uses a setTimeout function call which is hard coded to a fixed duration. See here: https://github.com/twbs/bootstrap/blob/v4-dev/js/src/carousel.js#L26 and https://github.com/twbs/bootstrap/blob/v4-dev/js/src/carousel.js#L383. Even if this matches the css transition duration for the carousel slide it appears that the setTimeout callback is being triggered before the transition is complete, remove the classes used during the transition and causing the "bounce".

Setting $carousel-transition: transform .5s ease-in-out; (so decreasing the transition duration by .1s) provides a workaround for this particular case but is not an ideal solution I think.

@Johann-S
Copy link
Member

Same behaviour on Edge

@mdo
Copy link
Member

mdo commented Apr 8, 2017

Dupe of #21685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants