Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons and input elements not inheriting $font-family-base #21652

Closed
dohayon opened this issue Jan 10, 2017 · 3 comments
Closed

Buttons and input elements not inheriting $font-family-base #21652

dohayon opened this issue Jan 10, 2017 · 3 comments
Labels
css has-pr v4
Milestone
v4.0.0-beta

Comments

@dohayon
Copy link

dohayon commented Jan 10, 2017

It seems like normalize is overriding the body with font-family: sans-serif, instead of reboot's setting of $font-family-base
@pvdlg
Copy link
Contributor

pvdlg commented Jan 10, 2017 •
edited
Loading

I think it's a duplicate of #21588

@pvdlg pvdlg mentioned this issue Jan 11, 2017
Closed
@maimairel
Copy link

maimairel commented Jan 12, 2017 •
edited
Loading

_reboot.scss

// Normalize includes `font: inherit;`, so `font-family`. `font-size`, etc are // properly inherited. However, `line-height` isn't inherited there.

But normalize doesn't inherit the font anymore.

@mdo
Copy link
Member

mdo commented Jan 16, 2017

Dupe of #21588.

@mdo mdo closed this as completed Jan 16, 2017
@mdo mdo added this to the v4.0.0-beta milestone Jan 21, 2017
@mdo mdo added the has-pr label Jan 21, 2017
@mdo mdo mentioned this issue Jan 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
5 participants
@mdo @bardiharborow @maimairel @pvdlg @dohayon