Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forms and fields with error messages #2156

Closed
nkryptic opened this issue Feb 22, 2012 · 4 comments
Closed

forms and fields with error messages #2156

nkryptic opened this issue Feb 22, 2012 · 4 comments

Comments

@nkryptic
Copy link
Contributor

This does have some overlap to issue #1939, but I'm targeting the overall use case for forms. It's fairly common to update a form with error messages using js or to display some error messages after an unsuccessful submission. Some errors might target a field, while other might be global in nature. See the following jsfiddle for examples:

http://jsfiddle.net/HFzQv/

The first form displayed has a form-level error message (not isolated to a certain field). One way to markup/style that would be for it to be an .alert, but I'm not certain if that is the correct usage and/or if you guys might have another approach in mind for this.

The second form shows a field in an error state with an error message for the field just before the field's .help-block providing general help on filling out the field. It seems like the error message for the field should stand out; as it is now, it seems lost along with the other text. Thoughts? (this is the part that is also addressed by #1939)

@andriijas
Copy link
Contributor

Feels like a duplicate of #1939

@nkryptic
Copy link
Contributor Author

@andriijas, I did mention twice that there was some overlap with #1939. But, I'm also including form-level errors as part of an overall issue where a design decision is needed.

@andriijas
Copy link
Contributor

I know you did, I just dont see any that you are adding that extra details to the issue but overhead of duplicate issue.

@mdo
Copy link
Member

mdo commented Feb 22, 2012

For general form errors, go ahead and use the alert component without a close icon. No need to create another pattern just for that.

Closing since that's addressed, and the rest is addressed in #1939.

@mdo mdo closed this as completed Feb 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants