Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom checkboxes don't work without indicator #21048

Closed
natcohen opened this issue Oct 30, 2016 · 9 comments
Closed

Custom checkboxes don't work without indicator #21048

natcohen opened this issue Oct 30, 2016 · 9 comments
Labels

Comments

@natcohen
Copy link

natcohen commented Oct 30, 2016

Custom checkboxes don't work without an indicator:

https://plnkr.co/edit/ZiJJbkXhCGwcLHpqsDr9?p=preview

@bardiharborow
Copy link
Member

bardiharborow commented Oct 31, 2016

Custom checkboxes appear to be broken in cases where the .custom-control-description label has no content or is missing.

@natcohen
Copy link
Author

Yes but there should be a way to create a custom checkbox without text...

@mdo
Copy link
Member

mdo commented Oct 31, 2016

Works fine for me I think. What's broken?

https://jsbin.com/jejefuh/edit?html,css,output

@natcohen
Copy link
Author

@mdo Did you check my plunker? I don't see what's different but yours works...

@bardiharborow
Copy link
Member

@mdo the crucial bit that I missed, is that this only happens with flexbox enabled.

@natcohen
Copy link
Author

natcohen commented Nov 1, 2016

@mdo the crucial bit that I missed, is that this only happens with flexbox enabled.

@bardiharborow Well... when using default (and not flexbox), I'm getting the same issue:
https://plnkr.co/edit/gPVBndoMC3rejmhxkJYx?p=preview

@mdo
Copy link
Member

mdo commented Nov 1, 2016

Could've been #20730? I'm using the latest CSS in my demo.

@natcohen
Copy link
Author

natcohen commented Nov 1, 2016

@mdo Maybe... Can you please check that it works with flexbox (I don't know how to get the latest version...) so I can close this issue?

@mdo
Copy link
Member

mdo commented Nov 4, 2016

I've updated my demo at https://jsbin.com/jejefuh/edit?html,css,output to be flexbox and it does work with the latest from v4-dev. Closing out.

I don't know how to get the latest version...

You can clone the project and switch to the v4-dev branch. Everything in the dist subdirectory should be the latest (or very close to it). Alternatively, you can download the compiled assets from our releases page.

@mdo mdo closed this as completed Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants