Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-height is not specified for page-links #21039

Closed
stefan-staynov opened this issue Oct 28, 2016 · 3 comments
Closed

line-height is not specified for page-links #21039

stefan-staynov opened this issue Oct 28, 2016 · 3 comments

Comments

@stefan-staynov
Copy link
Contributor

stefan-staynov commented Oct 28, 2016

I've noticed that the pagination component is slightly bigger than button's and form-control's. form-control's and button's have their line-height set to 1.25. This is not the case for page-link's. When I place a button or a form-control next to a pagination components, they look out of place. It makes sense to me to apply line-height: 1.25 to page-link as well and make all components the same height.

Here is an example of what I'm talking about: http://codepen.io/anon/pen/ALkJyw

Bootstrap v4 alpha5

@syhc
Copy link

syhc commented Nov 18, 2016

This solution will only solve regular and lg sized form-controland pagination.

In this example, you will notice that the button is slightly smaller: http://codepen.io/anon/pen/dONpgZ?

For sm, the pagination padding-y-sm: .275rem !default; differs from btn-paddding-y-sm: .25rem !default;.

@stefan-staynov
Copy link
Contributor Author

stefan-staynov commented Nov 19, 2016

Thanks for the info, I haven't noticed this. I will update the line-height property for all pagination sizes.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 28, 2016
@mdo
Copy link
Member

mdo commented Nov 28, 2016

Merged #21052 so closing. Thanks!

@mdo mdo closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants