Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .col and .row-* classes to support flex-direction: column. #20233

Closed
cgodo opened this issue Jul 5, 2016 · 3 comments
Closed

Add .col and .row-* classes to support flex-direction: column. #20233

cgodo opened this issue Jul 5, 2016 · 3 comments

Comments

@cgodo
Copy link

cgodo commented Jul 5, 2016

I saw there is no support for flex-direction, not being set anywhere so it uses the default value of "row".

I suggest to add .col and .row-* classes to support flex-direction: column. Those classes would be the same as current .row and .col-* classes, except that .col class would use flex-direction: column.

So Bootstrap 4 could have (using xs and 12 for this example):

<div class="row"> <!-- uses flex-direction: row -->
  <div class="col-xs-12"></div>
</div>

<div class="col"> <!-- uses flex-direction: column -->
  <div class="row-xs-12"></div>
</div>

<div class="row"> <!-- nesting -->
  <div class="col-xs-6 col">
    <div class="row-xs-6"></div>
    <div class="row-xs-6"></div>
  </div>
  <div class="col-xs-6 col">
    <div class="row-xs-6"></div>
    <div class="row-xs-6"></div>
  </div>
</div>

Of course, there should be some study about what do "xs", "md" and "lg" mean in the context of "column" layout. Media queries with screen height I suppose?

Cheers.

@cgodo cgodo changed the title Add .col and .row-* classes to support flex-direction: column. Bootstrap v4 - Add .col and .row-* classes to support flex-direction: column. Jul 5, 2016
@cgodo cgodo changed the title Bootstrap v4 - Add .col and .row-* classes to support flex-direction: column. Bootstrap 4 - Add .col and .row-* classes to support flex-direction: column. Jul 5, 2016
@cvrebert cvrebert changed the title Bootstrap 4 - Add .col and .row-* classes to support flex-direction: column. Add .col and .row-* classes to support flex-direction: column. Jul 6, 2016
@Mathdrquinn
Copy link

Being addressed in a new PR. I was looking for these same classes. I hope this helps.

@cvrebert
Copy link
Collaborator

Seems potentially confusing.
CC: @mdo

@mdo mdo modified the milestone: v4.0.0-alpha.4 Jul 28, 2016
@mdo mdo added this to the v4.0.0-alpha.5 milestone Aug 22, 2016
@mdo mdo modified the milestones: v4.0.0-alpha.5, v4.1 ideas Sep 12, 2016
@mdo mdo modified the milestones: v4.0.0-alpha.6, v4.1 ideas Dec 25, 2016
@mdo
Copy link
Member

mdo commented Dec 25, 2016

Tons of flex utils were added in #21407, so you can add .flex-column to any flex container and change the flex items accordingly.

@mdo mdo closed this as completed Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants