Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justified navbar missing classes [v4] #20031

Closed
ghost opened this issue Jun 3, 2016 · 3 comments
Closed

Justified navbar missing classes [v4] #20031

ghost opened this issue Jun 3, 2016 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 3, 2016

The issue - https://v4-alpha.getbootstrap.com/examples/justified-nav/

screen shot 2016-06-03 at 18 56 33

Expected result

screen shot 2016-06-03 at 18 55 59

The classes that fixed the issue:

.nav-justified > li {
   display: table-cell;
   width: 1%; 
   float: none;
   position: relative;
}

.nav > li > a {
    position: relative;
    display: block;
    padding 10px 15px;
}

Slightly modified ie10-viewport-bug-workaround.js

/*!
 * IE10 viewport hack for Surface/desktop Windows 8 bug
 * Copyright 2014-2015 Twitter, Inc.
 * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
 */

// See the Getting Started docs for more information:
// http://getbootstrap.com/getting-started/#support-ie10-width

(function () {
  'use strict';
  var msViewportStyle = null;

  if (navigator.userAgent.match(/IEMobile\/10\.0/)) {
    msViewportStyle = document.createElement('style');
    msViewportStyle.appendChild(
      document.createTextNode(
        '@-ms-viewport{width:auto!important}'
      )
    );
    document.getElementsByTagName('head')[0]
      .appendChild(msViewportStyle);
  }

})();
@ghost ghost changed the title Justified navbar missing rules [v4] Justified navbar missing classes [v4] Jun 3, 2016
@cvrebert cvrebert added js v4 css and removed js labels Jun 3, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented Jun 3, 2016

Duplicate of #17723. Please search more next time.

@cvrebert cvrebert closed this as completed Jun 3, 2016
@ghost
Copy link
Author

ghost commented Jun 3, 2016

I see, the justified classes have been removed in v4 without any explanation. What's the reason to add the v4 example page when those classes have been removed, do you have any plans to bring them back or they're completely gone ?

@cvrebert
Copy link
Collaborator

cvrebert commented Jun 3, 2016

The example wasn't added, it merely wasn't also removed.
Watch the other issue. It's all up to @mdo.

@twbs twbs locked and limited conversation to collaborators Jun 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant