Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested card-based accordions don't behave as expected #18632

Closed
aimeos opened this issue Dec 22, 2015 · 9 comments
Closed

Nested card-based accordions don't behave as expected #18632

aimeos opened this issue Dec 22, 2015 · 9 comments
Labels

Comments

@aimeos
Copy link

aimeos commented Dec 22, 2015

Accordions with nested cards don't open/close as expected: https://jsfiddle.net/6Laqymq0/

@cvrebert cvrebert changed the title [v4] Nested accordions don't behave as expected Nested accordions don't behave as expected Dec 23, 2015
@cvrebert
Copy link
Collaborator

X-Ref: #18160

@cvrebert cvrebert reopened this Dec 23, 2015
@cvrebert
Copy link
Collaborator

/me kicks @twbs-lmvtfy back to life
https://jsfiddle.net/6Laqymq0/

@twbs-lmvtfy
Copy link

Hi @cvrebert!

You appear to have posted a live example (https://fiddle.jshell.net/6Laqymq0/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

  • line 47, column 5 thru column 127: Attribute href not allowed on element div at this point.
  • line 51, column 5 thru column 127: Attribute href not allowed on element div at this point.
  • line 56, column 11 thru column 136: Attribute href not allowed on element div at this point.
  • line 60, column 11 thru column 136: Attribute href not allowed on element div at this point.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@cvrebert
Copy link
Collaborator

@aimeos Please fix those.

@aimeos
Copy link
Author

aimeos commented Dec 23, 2015

@cvrebert Makes no difference: https://fiddle.jshell.net/6Laqymq0/1/

@aimeos
Copy link
Author

aimeos commented Dec 23, 2015

@cvrebert As an improvement, a "data-href" attribute should be used so we aren't forced to add an tag only for the "href". It works well without the additional tag.

@cvrebert
Copy link
Collaborator

@aimeos The plugin already supports a data-target attribute for such cases.

@cvrebert
Copy link
Collaborator

I'm gonna say this is on-hold until we get Accordions working with Cards in the first place (#18375).
Once that's fixed, we'll recheck whether nested Card-based Accordions work properly.

@cvrebert cvrebert changed the title Nested accordions don't behave as expected Nested card-based accordions don't behave as expected Dec 23, 2015
@mdo
Copy link
Member

mdo commented Aug 4, 2017

Closing because I think #22251 addressed this? Please holler if not.

@mdo mdo closed this as completed Aug 4, 2017
@mdo mdo removed the on-hold label Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants