Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.table-responsive doesn't fill up width in Firefox #18612

Closed
aimeos opened this issue Dec 20, 2015 · 10 comments
Closed

.table-responsive doesn't fill up width in Firefox #18612

aimeos opened this issue Dec 20, 2015 · 10 comments

Comments

@aimeos
Copy link

aimeos commented Dec 20, 2015

When adding the v4 ".table-responsive" class to a table, the thead and tbody elements will use only the absolute necessary space in Firefox despite of the width of 100% of the table itself. This is due to the "display: block" necessary for the overflow.

@cvrebert cvrebert changed the title .table-reponsive doesn't fill up width in Firefox .table-responsive doesn't fill up width in Firefox Dec 20, 2015
@cvrebert
Copy link
Collaborator

Please post a JS Bin or JS Fiddle that demonstrates the problem.
A screenshot would also be appreciated.

@stephaniepurvis
Copy link
Contributor

Trying again (I can't seem to do anything right today!). I made a JS Fiddle of this issue here: https://jsfiddle.net/stephaniepurvis/pj6w2n64/6/

I don't see a problem with the table though. I am viewing this in Firefox 43.0.1 for Mac.

@aimeos
Copy link
Author

aimeos commented Dec 21, 2015

Sorry, my fault!
I've added ".table-responsive" to the table itself instead of wrapping a <div class="table-responsive"></div> around

@aimeos aimeos closed this as completed Dec 21, 2015
@cvrebert
Copy link
Collaborator

@Quy
Copy link

Quy commented Dec 22, 2015

Per Migrating to v4:
Responsive tables no longer require a wrapping element. Instead, just put the .table-responsive right on the <table>.

Will this be the case and just has not been implemented yet?

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 8, 2016

@mdo Are the docs wrong, or is the new .table-responsive broken?

@cvrebert
Copy link
Collaborator

@mdo Ping.

@creative3d
Copy link

Hello. Sorry to bother you. I've faced with the same issue, don't know how to solve it correctly because I need to change about thousand pages. Can't do this huge work twice or more.
The issue is not only with Firefox. So, if to wrap a table with div = table-responsive, then everything is fine (see the first table), but if just use a table with class = table-responsive, then the table don't expand 100% (see table 2).
screenshot
html file for testing
I'd like to know if this is gonna be fixed or should I wrap tables in div tags? I'm worried that div tags will stop working one day because it's kind of old feature... or will it be working forever? :)

@cvrebert
Copy link
Collaborator

@mdo PING.

@mdo mdo modified the milestone: v4.0.0-alpha.6 Oct 23, 2016
@mdo
Copy link
Member

mdo commented Nov 26, 2016

@mdo PING.

Hi there! Yes, I've been in and out and outlandishly unresponsive to almost everything. Apologies for that—getting caught up slowly but surely.

@mdo Are the docs wrong, or is the new .table-responsive broken?

It's now a modifier, not a wrapper. PR has been opened to address that.

Lastly, there's no bug here near as I can tell. FF50 and latest Safari look great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants