Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs plugin adds .active class to wrong element of correct tab when switching #18566

Closed
ditiem opened this issue Dec 13, 2015 · 2 comments
Closed

Tabs plugin adds .active class to wrong element of correct tab when switching #18566

ditiem opened this issue Dec 13, 2015 · 2 comments
Labels
confirmed has-pr js v4
Milestone
v4.0.0-beta

Comments

@ditiem
Copy link

ditiem commented Dec 13, 2015

The "active" class is set in the <li class="nav-item"> rather than the <a class="nav-link"> when you click on the "tab". The tap-panels are hidden and shown accordingly without any problem.

screen shot 2015-12-13 at 19 56 05
@cvrebert
Copy link
Collaborator

@ditiem This is regarding Bootstrap v4, correct?

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Dec 13, 2015
@cvrebert cvrebert changed the title Wrong render of tabs when using data-attributes to create them Tabs plugin adds .active class to wrong element of correct tab when switching Dec 13, 2015
@ditiem
Copy link
Author

ditiem commented Dec 13, 2015

@cvrebert Yes.

@mdo mdo modified the milestones: v4.0.0-alpha.3, v4.0.0-alpha.4 May 8, 2016
@alberto alberto mentioned this issue Jun 22, 2016
Closed
@CookingPixels CookingPixels mentioned this issue Jul 15, 2016
Closed
@cvrebert cvrebert mentioned this issue Aug 15, 2016
Closed
@mdo mdo modified the milestones: v4.0.0-alpha.5, v4.0.0-alpha.6 Oct 19, 2016
@mdo mdo mentioned this issue Nov 28, 2016
Closed
@mdo mdo added the confirmed label Nov 28, 2016
@mdo mdo mentioned this issue Nov 28, 2016
Closed
7 tasks
@mdo mdo modified the milestones: v4.0.0-alpha.6, v4.0.0-beta Jan 4, 2017
@pvdlg pvdlg mentioned this issue Jan 22, 2017
Merged
@mdo mdo added the has-pr label Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed has-pr js v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
3 participants
@mdo @cvrebert @ditiem