Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown's arrow key handler runs global DOM query? #18454

Closed
cvrebert opened this issue Dec 7, 2015 · 1 comment
Closed

Dropdown's arrow key handler runs global DOM query? #18454

cvrebert opened this issue Dec 7, 2015 · 1 comment

Comments

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 7, 2015

It seems rather odd that we're selecting all the dropdown items in the entire document in

let items = $.makeArray($(Selector.VISIBLE_ITEMS))

Surely we should be limiting the query to the descendants of the relevant dropdown menu? It seems rather unnecessarily wasteful otherwise.

@mdo
Copy link
Member

mdo commented Nov 26, 2016

Merged #19953, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants